fix: Fix getStreamingNetworkErrorMetadata to support videojs 7#1567
Open
idsulik wants to merge 2 commits intovideojs:mainfrom
Open
fix: Fix getStreamingNetworkErrorMetadata to support videojs 7#1567idsulik wants to merge 2 commits intovideojs:mainfrom
idsulik wants to merge 2 commits intovideojs:mainfrom
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1567 +/- ##
==========================================
- Coverage 84.00% 83.99% -0.01%
==========================================
Files 44 44
Lines 11707 11709 +2
Branches 2623 2624 +1
==========================================
+ Hits 9834 9835 +1
- Misses 1873 1874 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@mister-ben @gkatsev hi! Is there anything I can do to push the changes?) |
mister-ben
approved these changes
Apr 4, 2025
amtins
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1566
Specific Changes proposed
Added property existing checking to avoid exception if you use 7th version of the videojs
Requirements Checklist